[
https://issues.apache.org/jira/browse/CALCITE-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380943#comment-16380943
]
Julian Hyde commented on CALCITE-2045:
--------------------------------------
Reviewing
[2add2e4|https://github.com/apache/calcite/pull/638/commits/2add2e4dfd0916aea8061391c91f8148066981db]:
* It's a very good start. You've got the design exactly as I'd have done it.
* A few places (e.g. the `typeEntry` method, and in `JsonRoot`) you have
copy-pasted "table" stuff to "type", but haven't fixed all the comments.
* I'd rename `JsonAttribute` to `JsonTypeAttribute`
* for completeness we need a `DROP TYPE [IF EXISTS]` statement
* I don't like moving `SqlDdlNodes.schema` to `Util`. Maybe you need to create
`SqlValidatorUtil.getTypeEntry` similar to `getTableEntry`. And leave
`SqlDdlNodes.schema` where it is.
* The new error message in SqlValidatorTest.testCastFails is not good enough.
Should not contain 'UnsupportedOperationException'
* Need more tests in `SqlValidatorTest` (positive and negative, e.g. types
qualified by schema, referencing a type attribute
* Need a new test `type.iq` similar to `server/src/test/resources/sql/table.iq`
* Need some new sections in `model.md`
* In `reference.md`, don't use underscores; other identifiers are camel-case
> Support "CREATE TYPE" DDL
> -------------------------
>
> Key: CALCITE-2045
> URL: https://issues.apache.org/jira/browse/CALCITE-2045
> Project: Calcite
> Issue Type: New Feature
> Components: core
> Reporter: Shuyi Chen
> Assignee: Shuyi Chen
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
