[ 
https://issues.apache.org/jira/browse/CALCITE-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397280#comment-16397280
 ] 

Volodymyr Vysotskyi commented on CALCITE-2201:
----------------------------------------------

[~julianhyde], thanks for the review comments! 
I changed the method signatures to pass {{RelBuilder}} instead of 
{{RelBuilderFactory}} where possible and used {{call.builder()}} to receive 
{{RelBuilder}} instance inside rules.
Could you please take a look again?

> Allow passing custom RelBuilder into RelDecorrelator and 
> RelStructuredTypeFlattener
> -----------------------------------------------------------------------------------
>
>                 Key: CALCITE-2201
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2201
>             Project: Calcite
>          Issue Type: Task
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Julian Hyde
>            Priority: Major
>
> When {{RelDecorrelator.decorrelateQuery()}} method is called, 
> {{RelDecorrelator}} instance with {{RelFactories.LOGICAL_BUILDER}} is 
> created. We should modify this method to allow usage of custom {{RelBuilder}}.
> Also, {{RelStructuredTypeFlattener}} class should be modified in a similar 
> way.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to