[ 
https://issues.apache.org/jira/browse/CALCITE-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430398#comment-16430398
 ] 

Julian Hyde commented on CALCITE-2242:
--------------------------------------

Why does testFilterRemoveIsNotDistinctFromRuLe have so much code? It looks like 
there’s a lot of copy-pasted boilerplate. 

> Using custom RelBuilder for FilterRemoveIsNotDistinctFromRule
> -------------------------------------------------------------
>
>                 Key: CALCITE-2242
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2242
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.16.0
>            Reporter: Vitalii Diravka
>            Assignee: Vitalii Diravka
>            Priority: Major
>             Fix For: 1.17.0
>
>
> FilterRemoveIsNotDistinctFromRule doesn't leverage custom RelBuilder.
> There is no test case for this rule.
> {code}
> LogicalFilter(condition=[IS NOT DISTINCT FROM($7, 20)])
>   LogicalTableScan(table=[[scott, EMP]])
> {code}
> -->
> {code}
> LogicalFilter(condition=[CASE(IS NULL($7), IS NULL(20), =(CAST($7):TINYINT 
> NOT NULL, 20))])
>   LogicalTableScan(table=[[scott, EMP]])
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to