[ https://issues.apache.org/jira/browse/CALCITE-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437538#comment-16437538 ]
ASF GitHub Bot commented on CALCITE-1948: ----------------------------------------- Github user joshelser commented on a diff in the pull request: https://github.com/apache/calcite-avatica/pull/35#discussion_r181443036 --- Diff: docker/src/main/dockerhub-hypersql/Dockerfile --- @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to you under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +FROM apache/calcite-avatica:1.11.0 --- End diff -- Needs AVATICA_VERSION in here to make sure that we release a docker container with the appropriate version of Avatica we're releasing. Looks like sure docker/src/test/scripts/verify-dockerhub-dockerfile-version.groovy also needs updates to look at this new directory. > Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub > -------------------------------------------------------------------------- > > Key: CALCITE-1948 > URL: https://issues.apache.org/jira/browse/CALCITE-1948 > Project: Calcite > Issue Type: Improvement > Components: avatica > Reporter: Francis Chuang > Assignee: Josh Elser > Priority: Major > > I am currently making a port of the tests in calcite-avatica-go to test > against the calcite-avatica image in docker hub. > Unfortunately, the calcite-avatica image only includes the avatica-server, > which makes it difficult to stand up a test environment. > It would be nice if the docker images for HyperSQL, MySQL and Postgres can be > published as well. > This can be achieved by configuring docker hub's automatic build to look in > the appropriate subfolders for the dockerfile and push tags with the > appropriate backing db, for example 1.10.0-hypersql, 1.10.0-mysql etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)