[ 
https://issues.apache.org/jira/browse/CALCITE-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Volodymyr Vysotskyi updated CALCITE-2253:
-----------------------------------------
    Description: 
In CALCITE-2206 was prevented pushing windowed aggregates down for the 
{{SqlDialect}} s which do not support windowed functions.

After these changes, {{JdbcProjectRule}} is matched *only* for the cases when 
{{SqlDialect}} supports windowed functions and project contains windowed 
functions:
{code:java}
return out.dialect.supportsWindowFunctions()
    && !RexOver.containsOver(project.getProjects(), null);
{code}

It causes unit tests failures seen on the master.

  was:
In CALCITE-2206 was prevented pushing windowed aggregates down for the 
{{SqlDialect}} s which do not support windowed functions.

After these changes, {{JdbcProjectRule}} is matched *only* for the cases when 
{{SqlDialect}} supports windowed functions and project contains windowed 
functions:
{code:java}
return out.dialect.supportsWindowFunctions()
    && !RexOver.containsOver(project.getProjects(), null);
{code}

It causes unti tests 


> Fix matching predicate for JdbcProjectRule rule
> -----------------------------------------------
>
>                 Key: CALCITE-2253
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2253
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Julian Hyde
>            Priority: Major
>
> In CALCITE-2206 was prevented pushing windowed aggregates down for the 
> {{SqlDialect}} s which do not support windowed functions.
> After these changes, {{JdbcProjectRule}} is matched *only* for the cases when 
> {{SqlDialect}} supports windowed functions and project contains windowed 
> functions:
> {code:java}
> return out.dialect.supportsWindowFunctions()
>     && !RexOver.containsOver(project.getProjects(), null);
> {code}
> It causes unit tests failures seen on the master.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to