[
https://issues.apache.org/jira/browse/CALCITE-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439056#comment-16439056
]
Julian Hyde commented on CALCITE-2253:
--------------------------------------
Fixed in
[d83cb902|http://git-wip-us.apache.org/repos/asf/calcite/commit/d83cb902].
Thanks for the fix, [~vvysotskyi], and for the review, [~risdenk], and sorry I
broke it in the first place.
> Fix matching predicate for JdbcProjectRule rule
> -----------------------------------------------
>
> Key: CALCITE-2253
> URL: https://issues.apache.org/jira/browse/CALCITE-2253
> Project: Calcite
> Issue Type: Bug
> Components: jdbc-adapter
> Reporter: Volodymyr Vysotskyi
> Assignee: Julian Hyde
> Priority: Major
> Fix For: 1.17.0
>
>
> In CALCITE-2206 was prevented pushing windowed aggregates down for the
> {{SqlDialect}} s which do not support windowed functions.
> After these changes, {{JdbcProjectRule}} is matched *only* for the cases when
> {{SqlDialect}} supports windowed functions and project contains windowed
> functions:
> {code:java}
> return out.dialect.supportsWindowFunctions()
> && !RexOver.containsOver(project.getProjects(), null);
> {code}
> It causes unit tests failures seen on the master.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
