[
https://issues.apache.org/jira/browse/CALCITE-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443403#comment-16443403
]
Julian Hyde commented on CALCITE-2261:
--------------------------------------
Review comments:
* Can you use {{source=8 target=8}} rather than 1.8. The official name is JDK 8
not JDK 1.8.
* Make getSubSchema throw UnsupportedOperationException, to force sub-classes
to override.
* Add Bug.upgrade() somewhere to remind us to remove the workaround when we
upgrade to a version of janino that fixes the bug. Also mention the janino bug
number.
> Switch calcite-core to JDK8
> ---------------------------
>
> Key: CALCITE-2261
> URL: https://issues.apache.org/jira/browse/CALCITE-2261
> Project: Calcite
> Issue Type: Improvement
> Components: build
> Affects Versions: 1.16.0
> Reporter: Enrico Olivelli
> Assignee: Julian Hyde
> Priority: Major
> Fix For: 1.17.0
>
>
> Currently (1.16) Calcilte core is compiled for JDK 1.7.
> Just switching maven-compiler-plugin to 1.8 is not enough because of a bug of
> Janino
> [https://github.com/janino-compiler/janino/issues/47]
> reported by Vova
>
> As a workaround to that bug we have to add a default method implementation
> for SchemaPlus#getSubSchema
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
