[
https://issues.apache.org/jira/browse/CALCITE-2287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456987#comment-16456987
]
Julian Hyde commented on CALCITE-2287:
--------------------------------------
Please add some tests.
Calling {{Arrays.asList}} isn't very efficient. Maybe {{return o.size() == 3 &&
o.equals(this);}} (in Flat3List) will do the trick. The {{size == 3}} check
will ensure that it's not a Flat2List or Flat4List.
> StackOverflowError from FlatList equals()
> -----------------------------------------
>
> Key: CALCITE-2287
> URL: https://issues.apache.org/jira/browse/CALCITE-2287
> Project: Calcite
> Issue Type: Bug
> Reporter: Zhong Yu
> Assignee: Julian Hyde
> Priority: Major
>
> The equals() method of `Flat3List` and `Flat4List` may invoke each other in
> an infinite loop.
> See also https://issues.apache.org/jira/browse/HIVE-18427
>
> We found this problem when such lists are used as keys in
> `RelMetadataQuery.map`; occasionally there are hashcode collisions between
> `Flat3List` and `Flat4List`, hence their equals() methods will be invoked.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
