[
https://issues.apache.org/jira/browse/CALCITE-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496013#comment-16496013
]
Fei Xu commented on CALCITE-2336:
---------------------------------
Hi Julian, I change the code, e.g. but it seems doesn't help.
{code:java}
rootSchema = Frameworks.createRootSchema(true);
rootSchema.add("USERS", new AbstractTable() {
@Override public RelDataType getRowType(final RelDataTypeFactory
typeFactory) {
RelDataTypeFactory.FieldInfoBuilder builder = typeFactory.builder();
// builder.add("name", new BasicSqlType(new RelDataTypeSystemImpl() {},
SqlTypeName.BIGINT));
builder.add("name", typeFactory.createSqlType(SqlTypeName.BIGINT));
return builder.build();
}
});
final FrameworkConfig config = Frameworks.newConfigBuilder()
.parserConfig(SqlParser.Config.DEFAULT)
.defaultSchema(rootSchema)
.build();
planner = Frameworks.getPlanner(config);
dataContext = new MyDataContext(planner);
SqlNode parse =
planner.parse("insert into users select y, x\n"
+ "from (values (1, 'a'), (2, 'b'), (3, 'c')) as t(x, y)\n"
+ "where x > 1");
SqlNode validate = planner.validate(parse);
RelNode convert = planner.rel(validate).rel;
{code}
I still get the message
{code:java}
Caused by: java.lang.IndexOutOfBoundsException: index (1) must be less than
size (1)
at
com.google.common.base.Preconditions.checkElementIndex(Preconditions.java:310)
at
com.google.common.base.Preconditions.checkElementIndex(Preconditions.java:293)
at
com.google.common.collect.SingletonImmutableList.get(SingletonImmutableList.java:41)
at
org.apache.calcite.sql.validate.SqlValidatorImpl.validateSelectList(SqlValidatorImpl.java:3993)
at
org.apache.calcite.sql.validate.SqlValidatorImpl.validateSelect(SqlValidatorImpl.java:3251)
at
org.apache.calcite.sql.validate.SqlValidatorImpl.validateInsert(SqlValidatorImpl.java:4165)
at org.apache.calcite.sql.SqlInsert.validate(SqlInsert.java:148)
at
org.apache.calcite.sql.validate.SqlValidatorImpl.validateScopedExpression(SqlValidatorImpl.java:915)
at
org.apache.calcite.sql.validate.SqlValidatorImpl.validate(SqlValidatorImpl.java:625)
at org.apache.calcite.prepare.PlannerImpl.validate(PlannerImpl.java:194)
... 25 more
{code}
> SqlValidatorImpl throws java.lang.IndexOutOfBoundsException
> -----------------------------------------------------------
>
> Key: CALCITE-2336
> URL: https://issues.apache.org/jira/browse/CALCITE-2336
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Fei Xu
> Assignee: Julian Hyde
> Priority: Major
>
> I register a table "users" with a single column, age. And try to insert two
> columns into the "users".
> {code:java}
> rootSchema = Frameworks.createRootSchema(true);
> rootSchema.add("USERS", new AbstractTable() {
> @Override public RelDataType getRowType(final RelDataTypeFactory
> typeFactory) {
> RelDataTypeFactory.FieldInfoBuilder builder = typeFactory.builder();
> builder.add("age", new BasicSqlType(new RelDataTypeSystemImpl() {},
> SqlTypeName.CHAR));
> return builder.build();
> }
> });
> final FrameworkConfig config = Frameworks.newConfigBuilder()
> .parserConfig(SqlParser.Config.DEFAULT)
> .defaultSchema(rootSchema)
> .build();
> planner = Frameworks.getPlanner(config);
> dataContext = new MyDataContext(planner);
> SqlNode parse =
> planner.parse("insert into users select y, x\n"
> + "from (values (1, 'a'), (2, 'b'), (3, 'c')) as t(x, y)\n"
> + "where x > 1");
> SqlNode validate = planner.validate(parse);
> {code}
> Apparently, I want to see some error message like:
> {code:java}
> Number of INSERT target columns (1) does not equal number of source items (2)
> {code}
> But actually, I got message:
> {code:java}
> org.apache.calcite.tools.ValidationException:
> java.lang.IndexOutOfBoundsException: index (1) must be less than size (1)
> {code}
> which was confused.
> Then I debug the code in SqlValidatorImpl#validateSelectList method.
>
> {code:java}
> protected RelDataType validateSelectList(
> final SqlNodeList selectItems,
> SqlSelect select,
> RelDataType targetRowType) {
> // First pass, ensure that aliases are unique. "*" and "TABLE.*" items
> // are ignored.
> // Validate SELECT list. Expand terms of the form "*" or "TABLE.*".
> final SqlValidatorScope selectScope = getSelectScope(select);
> final List<SqlNode> expandedSelectItems = new ArrayList<>();
> final Set<String> aliases = Sets.newHashSet();
> final List<Map.Entry<String, RelDataType>> fieldList = new ArrayList<>();
> for (int i = 0; i < selectItems.size(); i++) {
> SqlNode selectItem = selectItems.get(i);
> if (selectItem instanceof SqlSelect) {
> handleScalarSubQuery(
> select,
> (SqlSelect) selectItem,
> expandedSelectItems,
> aliases,
> fieldList);
> } else {
> expandSelectItem(
> selectItem,
> select,
> targetRowType.isStruct()
> && targetRowType.getFieldCount() >= i
> ? targetRowType.getFieldList().get(i).getType()
> : unknownType,
> expandedSelectItems,
> aliases,
> fieldList,
> false);
> }
> }
> {code}
> See the exception is throw from here, if selectItems's size more than
> targetRowType's field count
> {code:java}
> && targetRowType.getFieldCount() >= i
> ? targetRowType.getFieldList().get(i).getType(){code}
> When I change it to this, I get what I need.
> {code:java}
> && targetRowType.getFieldCount() - 1 >= i
> ? targetRowType.getFieldList().get(i).getType(){code}
> So is this a Bug ? Do we need fix it ?
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
