[ 
https://issues.apache.org/jira/browse/CALCITE-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499701#comment-16499701
 ] 

godfrey he commented on CALCITE-2348:
-------------------------------------

It means the rules do't take care of non-deterministic operator ? 

Maybe we can ignore this transformation when the operator is non-deterministic 
to guarantee equivalent transformation for 

RelOptRule.

just like 
[HiveFilterAggregateTransposeRule|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterAggregateTransposeRule.java],
 
[HiveFilterJoinRule|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterJoinRule.java],
 
[HiveFilterProjectTransposeRule|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java],
 
[HiveFilterProjectTransposeRule|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java],
 
[HiveFilterSetOpTransposeRule|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSetOpTransposeRule.java]
 in hive.

PR for this: [https://github.com/apache/calcite/pull/717]


 Looking forward to your advice, many thanks!

> handling non-deterministic operator in rules
> --------------------------------------------
>
>                 Key: CALCITE-2348
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2348
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: godfrey he
>            Assignee: Julian Hyde
>            Priority: Major
>
> Currently,  rules do not handle non-deterministic operator,
> e.g. FilterAggregateTransposeRule can't push down a non-deterministic filter 
> through an aggregate.
> {code:java}
> // rand_substr is a non-deterministic udf
> @Test public void testPushFilterPastAggWithNondeterministicFilter() {
>   final String sql = "select ename, empno, c from\n"
>       + " (select ename, empno, count(*) as c from emp group by ename, empno) 
> t\n"
>       + " where rand_substr(ename, 1, 3) = 'Tom' and empno = 10";
>   checkPlanning(FilterAggregateTransposeRule.INSTANCE, sql);
> }{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to