[ 
https://issues.apache.org/jira/browse/CALCITE-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502184#comment-16502184
 ] 

Laurent Goujon commented on CALCITE-2352:
-----------------------------------------

At least 5.9 I believe for lambda, and probably 6.1. I did several tries and 
run into several issues:
- maven-checkstyle-plugin 3.0.0 (which would be 6.18) has some guava issue with 
maven or another plugin, causing the project to fail right away. Previous 
plugin version (2.17) seems okay though
- recent versions of checkstyle (8.2 or higher) removed FileContentHolder 
module, and it seems it might require a new build of hydromatic-toolbox as the 
checkstyle verifier is probably depending on it
- depending on which checkstyle version being used, it generates betweem 100 
and 200 violations.

Calcite seems to be on 3.0.0 plugin/Checkstyle 6.18 btw


> Upgrade checkstyle to support Java8 lambdas
> -------------------------------------------
>
>                 Key: CALCITE-2352
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2352
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>            Reporter: Laurent Goujon
>            Priority: Major
>
> Version of checkstyle used by Avatica (5.7) doesn't support constructs from 
> Java8 like lambdas and static methods in interfaces.
> This would result in lots of small changes to adjust to the stricter rules.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to