[ 
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506568#comment-16506568
 ] 

Andrei Sereda commented on CALCITE-2345:
----------------------------------------

I took the liberty to create {{zips-mini.json}} for ES adapter test (see 
[716|https://github.com/apache/calcite/pull/716]). It is a subset of zips but 
reduced to 149 records: top 3 cities by population for each state.

Some questions:
1. Should all adapters use identical dataset ? (probably yes)
2. Should unit and integration tests share same dataset ? (probably yes)
3. How to share this static file among calcite test modules ? (currently it is 
cloned)
4. For document databases, should we continue using zips schema or create 
something more complicated with nested objects / arrays / booleans etc. 
([generator example|https://mockaroo.com/])



> add tests using Fongo to Mongo Adapter
> --------------------------------------
>
>                 Key: CALCITE-2345
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2345
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Andrei Sereda
>            Assignee: Michael Mior
>            Priority: Major
>
> Better test coverage for unit tests using 
> [Fongo|https://github.com/fakemongo/fongo] which is in-memory implementation 
> of Mongo API.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to