[
https://issues.apache.org/jira/browse/CALCITE-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522676#comment-16522676
]
Julian Hyde commented on CALCITE-2363:
--------------------------------------
I took a quick look. Looks OK, albeit a bit more verbose, and yes, it does
break compatibility. I will review more thoroughly, but first I would like
someone else to review.
Is this change a net improvement?
> Refactor RelShuttle not to depend on structures of RelNodes
> -----------------------------------------------------------
>
> Key: CALCITE-2363
> URL: https://issues.apache.org/jira/browse/CALCITE-2363
> Project: Calcite
> Issue Type: Improvement
> Reporter: Teruyoshi Zenmyo
> Assignee: Julian Hyde
> Priority: Major
>
> Currently, RelShuttle implementations depends on the structures of RelNodes.
> For instance, RelShuttleImp.visit(LogicalAggregate aggregate) knows the first
> element of getInput() is the next element to be visited.
> [https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/RelShuttleImpl.java#L75]
>
> By this refactoring, implementations of RelShuttle will become free from
> invoking super.visit methods.
> https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql2rel/CorrelationReferenceFinder.java#L61
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
