[ 
https://issues.apache.org/jira/browse/CALCITE-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536497#comment-16536497
 ] 

Julian Hyde commented on CALCITE-2299:
--------------------------------------

I reviewed. Looks good, except that in the line
{code:java}BigDecimal.ONE.divide(unit.multiplier, 
BigDecimal.ROUND_UNNECESSARY));{code} both {{divide}} and {{ROUND_UNNECESSARY}} 
are deprecated. Can you fix ASAP please.

> TIMESTAMPADD(SQL_TSI_FRAC_SECOND) should be nanoseconds not microseconds
> ------------------------------------------------------------------------
>
>                 Key: CALCITE-2299
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2299
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.16.0
>            Reporter: James Duong
>            Assignee: Julian Hyde
>            Priority: Minor
>             Fix For: avatica-1.13.0
>
>
> When calling TIMESTAMPADD with the first parameter SQL_TSI_FRAC_SECOND and 
> the JDBC escape sequence, this gets interpreted as microseconds when it 
> should be interpreted as nanoseconds.
>  
> From the ODBC spec on MSDN:
> [https://docs.microsoft.com/en-us/sql/odbc/reference/appendixes/time-date-and-interval-functions?view=sql-server-2017]
> 'where fractional seconds are expressed in billionths of a second.'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to