[ 
https://issues.apache.org/jira/browse/CALCITE-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549926#comment-16549926
 ] 

Laurent Goujon commented on CALCITE-2421:
-----------------------------------------

why is it an incorrect simplification if NULL is considered as FALSE (Of course 
assuming that A and B are deterministic)? 
A=A is always TRUE, except if A is NULL, in which case result would be NULL 
(and so would be considered as FALSE), isn't it?

> RexSimplify#simplifyAnds foregoes some simplications if unknownAsFalse set to 
> true
> ----------------------------------------------------------------------------------
>
>                 Key: CALCITE-2421
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2421
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Laurent Goujon
>            Assignee: Julian Hyde
>            Priority: Minor
>
> It looks like {{RexSimplify#simplifyAnds}} foregoes some comparison 
> simplifications if {{unknownAsFalse}} is set to true, like {{A = A AND B = 
> B}} which might be simplified to {{A IS NOT NULL AND B IS NOT NULL}} or even 
> {{true}} if {{A}} and {{B}} are known to be not nullable.
> One consequence of this is that the selectivity value might be off as a {{=}} 
> comparison has a selectivity of 15% whereas {{ IS NOT NULL }} has a 
> selectivity of 90%.
> The simplication is skipped because {{RexSimplify#simplifyList}} simplify all 
> terms with {{unknownAsFalse}} set to {{false}}, but in 
> {{RexSimplify#simplifyAnd2ForUnknownAsFalse}}, there's no attempt at trying 
> again to simplify each term.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to