[
https://issues.apache.org/jira/browse/CALCITE-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566495#comment-16566495
]
Vladimir Sitnikov commented on CALCITE-2435:
--------------------------------------------
Java 1.8.0u152, macOS 10.13.5, 4 core, 8 threads.
{noformat}
# on a refactor_ssltestfactory branch
mvn surefire:test > p1
mvn surefire:test > p2
mvn surefire:test > p3
mvn surefire:test > p4
git checkout master
mvn clean
mvn install
mvn surefire:test > o1
mvn surefire:test > o2
mvn surefire:test > o3
mvn surefire:test > o4
mvn surefire:test > o5
mvn surefire:test > o6
git checkout refactor_ssltestfactory
mvn clean
mvn install
mvn surefire:test > p11
mvn surefire:test > p12
mvn surefire:test > p13{noformat}
The results are as follows:
{noformat}
grep 'Total time' p? o? p1?
"with fix"
p1:[INFO] Total time: 03:33 min
p2:[INFO] Total time: 03:30 min
p3:[INFO] Total time: 03:31 min
p4:[INFO] Total time: 03:32 min
"master"
o1:[INFO] Total time: 03:33 min
o2:[INFO] Total time: 03:30 min
o3:[INFO] Total time: 03:35 min
o4:[INFO] Total time: 03:31 min
o5:[INFO] Total time: 03:35 min
o6:[INFO] Total time: 03:28 min
"with fix"
p11:[INFO] Total time: 03:30 min
p12:[INFO] Total time: 03:31 min
p13:[INFO] Total time: 03:34 min{noformat}
That is the fix has no impact on the test duration.
> Refactor SqlTestFactory
> -----------------------
>
> Key: CALCITE-2435
> URL: https://issues.apache.org/jira/browse/CALCITE-2435
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
>
> Current SqlTestFactory/DelegatingSqlTestFactory is hard to reason about, and
> it is hard to extend/cache properly.
> There are three key changes here:
> 1. Rename DefaultSqlTestFactory to SqlTestFactory. SqlTestFactory was an
> interface, however it has a single viable implementation, so it makes little
> sense to keep it as is.
> 2. Move MockCatalogReader.init and MockCatalogReader.init2 to
> MockCatalogReaderSimple and MockCatalogReaderExtended
> 3. Move MockCatalogReader to its own package, and split several inner classes
> to a top-level ones.
> 4. Replace usages
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
