[
https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571232#comment-16571232
]
Vladimir Sitnikov commented on CALCITE-2438:
--------------------------------------------
Feel free to do with this Jira case whatever you like.
I am -1 for committing [https://github.com/apache/calcite/pull/778] with the
following justification:
1) The added test testIsAlwaysTrueAndFalse is hard to read. It is obscure which
cases it verifies
2) The added test testIsAlwaysTrueAndFalse would produce obscure error messages
if the test fails. That is maintenance cost for the test is extremely high.
3) It looks like the number of tests is not enough: the test covers only
positive cases, and negative ones go untested.
> RexCall#isAlwaysTrue return incorrect result
> ---------------------------------------------
>
> Key: CALCITE-2438
> URL: https://issues.apache.org/jira/browse/CALCITE-2438
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.17.0
> Reporter: pengzhiwei
> Assignee: Julian Hyde
> Priority: Critical
> Attachments: 屏幕快照 2018-08-02 下午7.26.20.png, 屏幕快照 2018-08-02
> 下午7.34.26.png
>
>
> In the expression as followed:
> {code:java}
> ((sal IS NULL) IS NOT NULL) IS FALSE
> {code}
> The RexCall#isAlwaysTrue return true,however the correct answer is false.
> I find the reason is that there is a wrong logic in the isAlwaysTrue,when
> getKind() is IS_NOT_FALSE、IS_FALSE and IS_NOT_FALSE :
> !屏幕快照 2018-08-02 下午7.34.26.png!
> Can you have a check for me,thanks!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
