[
https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572378#comment-16572378
]
Vladimir Sitnikov commented on CALCITE-2438:
--------------------------------------------
{quote}The messages have less information content than the stack trace
{quote}
Which messages do you mean.
Of course messages like {{"expected false,but got true in
isTrueExp2.isAlwaysTrue()"}} add no value, and I have never suggested adding
them.
{quote}content than the stack trace
{quote}
Test method contains lots of cases. Suppose a couple of them breaks in **CI**
Then you would have error messages like "assertionError: true expected [true]
got [false] at like 34236".
That is one of the worst test outputs one can imagine.
> RexCall#isAlwaysTrue return incorrect result
> ---------------------------------------------
>
> Key: CALCITE-2438
> URL: https://issues.apache.org/jira/browse/CALCITE-2438
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.17.0
> Reporter: pengzhiwei
> Assignee: Julian Hyde
> Priority: Critical
> Attachments: 屏幕快照 2018-08-02 下午7.26.20.png, 屏幕快照 2018-08-02
> 下午7.34.26.png
>
>
> In the expression as followed:
> {code:java}
> ((sal IS NULL) IS NOT NULL) IS FALSE
> {code}
> The RexCall#isAlwaysTrue return true,however the correct answer is false.
> I find the reason is that there is a wrong logic in the isAlwaysTrue,when
> getKind() is IS_NOT_FALSE、IS_FALSE and IS_NOT_FALSE :
> !屏幕快照 2018-08-02 下午7.34.26.png!
> Can you have a check for me,thanks!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
