[
https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572822#comment-16572822
]
Vladimir Sitnikov edited comment on CALCITE-2438 at 8/8/18 9:04 AM:
--------------------------------------------------------------------
{quote}If I know the file, the line number and the commit hash, that's better
than the message.{quote}
Test failures should look like a decent bug report, not like "something went
wrong".
{quote}If I know the file, the line number and the commit hash, that's better
than the message.{quote}
Test failures should look like a decent bug report, not like "something went
wrong".
And test failures should be easy to understand by a developer (different from
the one that created the test in the first place).
"expected: is<true> but was: <false> at line 3745" is hard to understand. This
is especially important to avoid time spent on analyzing failures that was
triggered by "unrelated" changes (for instance if new code is added to isAlways
or in case a fix lands to RexSimplify).
was (Author: vladimirsitnikov):
{quote}If I know the file, the line number and the commit hash, that's better
than the message.{quote}
Test failures should look like a decent bug report, not like "something went
wrong".
{quote}If I know the file, the line number and the commit hash, that's better
than the message.{quote}
Test failures should look like a decent bug report, not like "something went
wrong".
And test failures should be easy to understand by a developer (different from
the one that created the test in the first place).
"expected: is<true> but was: <false> at line 3745" is hard to understand. This
is especially important to avoid time spent on analyzing failures that was
triggered by "unrelated" changes (for instance if new code is added to
isAlways).
> RexCall#isAlwaysTrue return incorrect result
> ---------------------------------------------
>
> Key: CALCITE-2438
> URL: https://issues.apache.org/jira/browse/CALCITE-2438
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.17.0
> Reporter: pengzhiwei
> Assignee: Julian Hyde
> Priority: Critical
> Attachments: 屏幕快照 2018-08-02 下午7.26.20.png, 屏幕快照 2018-08-02
> 下午7.34.26.png
>
>
> In the expression as followed:
> {code:java}
> ((sal IS NULL) IS NOT NULL) IS FALSE
> {code}
> The RexCall#isAlwaysTrue return true,however the correct answer is false.
> I find the reason is that there is a wrong logic in the isAlwaysTrue,when
> getKind() is IS_NOT_FALSE、IS_FALSE and IS_NOT_FALSE :
> !屏幕快照 2018-08-02 下午7.34.26.png!
> Can you have a check for me,thanks!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
