[
https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573851#comment-16573851
]
Julian Hyde commented on CALCITE-2453:
--------------------------------------
Reviewing [PR 783|https://github.com/apache/calcite/pull/783]:
* Can you make {{handleException}} return an exception, that the caller has to
throw, rather than returning void. (I don't like the 'return null;' in the
catch block that will never be reached.)
* Can you change {{checkStmts(String sql, String expected)}} to
{{checkList(String sql, List<String> expected)}}? Tests are clearer if they
contain a list of individual strings.
* Might we worth adding a test where a semicolon occurs inside a comment or
character literal.
* In a sequence of statements, the semicolons between statements are necessary,
but is the semicolon after the last statement necessary? It don't care which,
but please be explicit in the method documentation.
These are minor points; your change looks good overall.
> Enhance the SQL parser in order to optionally support semicolon at the end of
> the sql statements
> ------------------------------------------------------------------------------------------------
>
> Key: CALCITE-2453
> URL: https://issues.apache.org/jira/browse/CALCITE-2453
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: next
> Reporter: charbel yazbeck
> Assignee: Julian Hyde
> Priority: Trivial
> Attachments:
> 0001-CALCITE-2453-Allowing-SQL-statements-to-optionally-e.patch
>
>
> Consists of adding [<SEMICOLON>] in Parser.jj
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
