[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575102#comment-16575102
]
Vladimir Sitnikov edited comment on CALCITE-2457 at 8/9/18 4:34 PM:
--------------------------------------------------------------------
{quote}assertThat(Sql.create("select * from ...")).hasLogicalPlan("....",
"...");{quote}
Is that much different from existing
[sql(sql).ok()|https://github.com/apache/calcite/blob/96b28f7ba11de22a68d984de6b6b88311cc2c57e/core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java#L104]
?
was (Author: vladimirsitnikov):
{quote}assertThat(Sql.create("select * from ...")).hasLogicalPlan("....",
"...");{quote}
Is that much different from existing {{sql(sql).ok()}} ?
> Upgrade to JUnit 5
> ------------------
>
> Key: CALCITE-2457
> URL: https://issues.apache.org/jira/browse/CALCITE-2457
> Project: Calcite
> Issue Type: Improvement
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
> Attachments: assert_equals.png, truth_assertmap.png
>
>
> JUnit 5 brings multiple useful features so tests are easier to read and write.
> Is there something that blocks upgrading to JUnit 5?
> By upgrade I mean bumping up the dependency version and creating new tests
> with JUnit 5 features.
> Relevant features of JUnit 5: dynamic test, nested tests, parameterized tests
> https://twitter.com/nipafx/status/1027095088059559936
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
