[ 
https://issues.apache.org/jira/browse/CALCITE-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581437#comment-16581437
 ] 

ASF GitHub Bot commented on CALCITE-2467:
-----------------------------------------

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/calcite-avatica/pull/66#discussion_r210359691
  
    --- Diff: 
server/src/main/java/org/apache/calcite/avatica/server/PropertyBasedSpnegoLoginService.java
 ---
    @@ -60,7 +61,8 @@ public PropertyBasedSpnegoLoginService(String realm, 
String serverPrincipal) {
         targetNameField.set(this, serverPrincipal);
       }
     
    -  @Override public UserIdentity login(String username, Object credentials) 
{
    +  @Override public UserIdentity login(String username, Object credentials,
    +      ServletRequest request) {
    --- End diff --
    
    From the looks of 
https://github.com/eclipse/jetty.project/commit/c23f21c761ff56f2ad4841a98083b237494442de,
 the method signature changed, but there were no changes of consequence in 
SpnegoLoginService. We're good.


> Upgrade owasp-dependency-check maven plugin to 3.3.1
> ----------------------------------------------------
>
>                 Key: CALCITE-2467
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2467
>             Project: Calcite
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.17.0, avatica-1.12.0
>            Reporter: Albert Baker
>            Assignee: Julian Hyde
>            Priority: Minor
>
> In pom.xml, upgrade <owasp-dependency-check.version> maven plugin from 2.1.1 
> to 3.3.1 (current version).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to