[ 
https://issues.apache.org/jira/browse/CALCITE-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Sitnikov updated CALCITE-2479:
---------------------------------------
    Description: 
Case for SqlAdvisorTest:
{code:java}  @Test @WithLex(Lex.JAVA) public void testAdviceExpression() {
    String sql;
    sql = "select s.`count`+s.co^ from (select 1 `count` from emp) s";
    assertComplete(sql, "COLUMN(count)\n", "co",
        ImmutableMap.of("COLUMN(count)", "`count`"));
  }
{code}

It should automatically quote the suggested column name {{count}} since 
otherwise it is confused with {{count}} keyword.

  was:
Case for SqlAdvisorTest:
{code:java}  @Ignore("It looks like s.count clashes with COUNT keyword, however 
the same SQL executes just fine")
  @Test @WithLex(Lex.JAVA) public void testAdviceExpression() {
    String sql;
    sql = "select s.count+s.co^ from (select 1 count from emp) s";
    assertComplete(sql, "COLUMN(count)\n", "co",
        ImmutableMap.of("COLUMN(count)", "count"));
  }
{code}

It is not clear why SQL fails to advise, however the same query works just fine 
via JDBC.


> SqlAdvisor: automatically quote SQL keywords
> --------------------------------------------
>
>                 Key: CALCITE-2479
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2479
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>            Priority: Major
>
> Case for SqlAdvisorTest:
> {code:java}  @Test @WithLex(Lex.JAVA) public void testAdviceExpression() {
>     String sql;
>     sql = "select s.`count`+s.co^ from (select 1 `count` from emp) s";
>     assertComplete(sql, "COLUMN(count)\n", "co",
>         ImmutableMap.of("COLUMN(count)", "`count`"));
>   }
> {code}
> It should automatically quote the suggested column name {{count}} since 
> otherwise it is confused with {{count}} keyword.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to