[
https://issues.apache.org/jira/browse/CALCITE-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594893#comment-16594893
]
Vladimir Sitnikov commented on CALCITE-2327:
--------------------------------------------
[~kgyrtkirk], thanks for working on this, however your approach is PR707
completely off the track:
1) It removes the optimization instead of fixing a bug
2) It touches extra lines that do not belong to the issue
Please use `vBool(0)` and `vBool(1)` when creating tests with dynamic params,
it makes the test easier to read (there's no need to have RelDataType/RexNode
preparation in the test code).
{quote} Unfortunately the patch you submitted still suffer from
oversimplification{quote}
Thanks for the test case.
I have added the case (and a couple of more) in
[c8e91ea1db1e519d9d73bbb8b08ee27f710cb1d4|https://git-wip-us.apache.org/repos/asf?p=calcite.git;a=commit;h=c8e91ea1db1e519d9d73bbb8b08ee27f710cb1d4]
> In 3 valued logic mode (b and not b) may not be simplified to false
> -------------------------------------------------------------------
>
> Key: CALCITE-2327
> URL: https://issues.apache.org/jira/browse/CALCITE-2327
> Project: Calcite
> Issue Type: Bug
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Fix For: 1.18.0
>
>
> currently its simplified to false; but that is not correct when a is unknown
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
