[ 
https://issues.apache.org/jira/browse/CALCITE-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596752#comment-16596752
 ] 

Julian Hyde commented on CALCITE-2496:
--------------------------------------

Looks good. Your parser change (perhaps unintentionally) enables NANOSECOND as 
an argument for CEIL and FLOOR. Can you add tests for those.

> EXTRACT function: MILLI/MICRO/NANOSECOND parts of a DATE must be zero
> ---------------------------------------------------------------------
>
>                 Key: CALCITE-2496
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2496
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: Sergey Nuyanzin
>            Assignee: Julian Hyde
>            Priority: Major
>
> There was already a similar issue CALCITE-2324 but I'm sorry I did not take 
> into account 3 time units. Now I want to cover them here. So all existing 
> Timeunits from {{org.apache.calcite.avatica.util.TimeUnit}} which are less 
> than a day will be covered



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to