[
https://issues.apache.org/jira/browse/CALCITE-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605097#comment-16605097
]
Julian Hyde commented on CALCITE-2537:
--------------------------------------
OK, I take your point about logging not changing behavior.
Maybe you should change the {{validate}} method to take a {{Litmus}} argument,
and use it instead of explicitly calling {{throw AssertionError}}. Then you can
invoke it as follows: {code}if (LOGGER.isDebugEnabled()) {
assert validate(Litmus.THROW);
}{code}
> Make sure assertions are enabled before calling VolcanoPlanner#validate
> -----------------------------------------------------------------------
>
> Key: CALCITE-2537
> URL: https://issues.apache.org/jira/browse/CALCITE-2537
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Laurent Goujon
> Assignee: Julian Hyde
> Priority: Minor
>
> {{VolcanoPlanner#validate()}} is invoked if the log level is debug or lower.
> But considering how enabling this method slows down the whole planning
> (changing it for running tests make the whole duration several hours), and
> this is some kind of assertion (since it throws {{AssertionError}}, I would
> suggest to only enable it when assertions are enabled
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
