[
https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608877#comment-16608877
]
Hongze Zhang edited comment on CALCITE-2535 at 9/10/18 8:41 AM:
----------------------------------------------------------------
[~vladimirsitnikov] Thanks for your comment:
{quote}Would you please clarify what is the nature of changes to
org.apache.calcite.linq4j.tree.DeterministicCodeOptimizer?
{quote}
This is to expose original exception in function run. Currently the exception
could be wrapped with ExceptionInInitializerError.
{quote}How DCO is relevant to this JIRA issue?
{quote}
It could be better to use the original produced exception for function
execution failure test rather than stripping and check the
ExceptionInInitializerError.
{quote}Would you please add tests cases for the changes to DCO?
{quote}
Thank you for your suggestion, I have add a test case for the DCO thange at the
[latest
commit|https://github.com/apache/calcite/pull/821/commits/cfd127f04c2f004a487a25b7c09c78c81ed24956].
was (Author: zhztheplayer):
[~vladimirsitnikov] Thanks for your comment:
{quote}Would you please clarify what is the nature of changes to
org.apache.calcite.linq4j.tree.DeterministicCodeOptimizer?
{quote}
This is to expose original exception in function run. Currently the exception
could be wrapped with ExceptionInInitializerError.
{quote}How DCO is relevant to this JIRA issue?
{quote}
It could be better to use the original produced exception for function
execution failure test rather than stripping and check the
ExceptionInInitializerError.
{quote}Would you please add tests cases for the changes to DCO?
{quote}
Thank you for your suggestion, I have add a test case for the DCO thange at the
[latest
commit|https://github.com/apache/calcite/pull/821/commits/7fcfac7eb6701ca8e2a575de2800f097058c8845].
> Runtime failure check not working in SqlTesterImpl.java
> -------------------------------------------------------
>
> Key: CALCITE-2535
> URL: https://issues.apache.org/jira/browse/CALCITE-2535
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Hongze Zhang
> Assignee: Julian Hyde
> Priority: Major
>
> Problem at SqlTesterImpl#checkFails:
> When argument "runtime" is specified as true, error assertion and error
> message matching will not be performed.
> This issue could result in wrong test result in SqlOperatorBaseTest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
