[
https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608957#comment-16608957
]
Vladimir Sitnikov commented on CALCITE-2535:
--------------------------------------------
A site note: I see you split SqlTester into multiple classes
(SqlValidatorTester, SqlRuntimeTester, +there's old TesterImpl).
Could you please clarify why extra classes are required?
I struggle to understand what those classes do. I struggle to understand how
they differ. Isn't a single tester enough?
While I do agree previous code was moot as well, however it is extremely hard
to review the change when you don't understand what the new code is doing.
> Runtime failure check not working in SqlTesterImpl.java
> -------------------------------------------------------
>
> Key: CALCITE-2535
> URL: https://issues.apache.org/jira/browse/CALCITE-2535
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Hongze Zhang
> Assignee: Julian Hyde
> Priority: Major
>
> Problem at SqlTesterImpl#checkFails:
> When argument "runtime" is specified as true, error assertion and error
> message matching will not be performed.
> This issue could result in wrong test result in SqlOperatorBaseTest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
