[
https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612131#comment-16612131
]
Hongze Zhang edited comment on CALCITE-2535 at 9/13/18 9:15 AM:
----------------------------------------------------------------
[~julianhyde]
Please correct me if I am wrong. The solution for this issue should includes:
# To make the SqlTesterImpl#checkFails really perform a complete SQL execution;
# To change the test case in SqlTesterImpl#checkFails, in order to avoid
possible constant folding;
# FNL-3: To give Calcite the ability to throw a java.sql.SQLException (or some
other checked exception with a pre-defined SQL state) at runtime execution.
I have changed [PR#823|https://github.com/apache/calcite/pull/823] to implement
1 and 2(For 2, use SqlTesterImpl#buildQuery2).
I propose to give 3 a lower priority, maybe open another issue for that.
was (Author: zhztheplayer):
[~julianhyde]
Please correct me if I am wrong. The solution for this issue should includes:
# To make the SqlTesterImpl#checkFails really perform a complete SQL execution;
# To change the test case in SqlTesterImpl#checkFails, in order to avoid
possible constant folding;
# FNL-3: To give Calcite the ability to throw a java.sql.SQLException (with a
pre-defined SQL state) at runtime execution.
I have changed [PR#823|https://github.com/apache/calcite/pull/823] to implement
1 and 2(For 2, use SqlTesterImpl#buildQuery2).
I propose to give 3 a lower priority, maybe open another issue for that.
> Runtime failure check not working in SqlTesterImpl.java
> -------------------------------------------------------
>
> Key: CALCITE-2535
> URL: https://issues.apache.org/jira/browse/CALCITE-2535
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Hongze Zhang
> Assignee: Julian Hyde
> Priority: Major
>
> Problem at SqlTesterImpl#checkFails:
> When argument "runtime" is specified as true, error assertion and error
> message matching will not be performed.
> This issue could result in wrong test result in SqlOperatorBaseTest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
