[ 
https://issues.apache.org/jira/browse/CALCITE-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Sitnikov resolved CALCITE-2524.
----------------------------------------
    Resolution: Not A Problem

javacc-maven-plugin is good enough.
compilation will be fixed in CALCITE-2558

> JavaCC updates SqlParserImpl*.java files, and it causes long compilations
> -------------------------------------------------------------------------
>
>                 Key: CALCITE-2524
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2524
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>            Priority: Major
>
> {noformat}[DEBUG] CompilerReuseStrategy: reuseCreated
> [DEBUG] useIncrementalCompilation enabled
> [DEBUG] Stale source detected: 
> /Users/vladimirsitnikov/Documents/code/calcite/core/target/generated-sources/javacc/org/apache/calcite/sql/parser/impl/SqlParserImplTokenManager.java
> [DEBUG] Stale source detected: 
> /Users/vladimirsitnikov/Documents/code/calcite/core/target/generated-sources/javacc/org/apache/calcite/sql/parser/impl/SqlParserImplConstants.java
> [DEBUG] Stale source detected: 
> /Users/vladimirsitnikov/Documents/code/calcite/core/target/generated-sources/javacc/org/apache/calcite/sql/parser/impl/SqlParserImpl.java
> [INFO] Changes detected - recompiling the module!
> {noformat}
> It looks like we could treat that by teaching javacc-maven-plugin to check if 
> destination files match the desired contents before overwriting them 
> (~something like https://github.com/julianhyde/hydromatic-resource/pull/4).
> The sad thing is https://github.com/mojohaus/javacc-maven-plugin seems to be 
> unmaintained.
> Are there any plans re JavaCC? (e.g. 
> https://github.com/phax/ParserGeneratorCC)
> I see two options:
> 1) Fork https://github.com/mojohaus/javacc-maven-plugin and publish the 
> plugin with alternative coordinates. For instance, I can easily push to 
> com.github.vlsi....
> 2) Switch to ParserGeneratorCC and file a PR there
> 3) File a PR to https://github.com/mojohaus/javacc-maven-plugin, however I 
> suspect that repository is no longer maintained.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to