[
https://issues.apache.org/jira/browse/CALCITE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Sitnikov resolved CALCITE-2559.
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.18.0
Fixed in
https://git-wip-us.apache.org/repos/asf?p=calcite.git;a=commit;h=4b4d8037c5073e4eb5702b12bc4ecade31476616
> Upgrade Checkstyle to 7.8.2
> ---------------------------
>
> Key: CALCITE-2559
> URL: https://issues.apache.org/jira/browse/CALCITE-2559
> Project: Calcite
> Issue Type: Bug
> Reporter: Vladimir Sitnikov
> Assignee: Vladimir Sitnikov
> Priority: Major
> Fix For: 1.18.0
>
>
> {noformat}mvn clean validate for various:
> 6.x 7.8.2 <-- checkstyle version
> 19.7 18.3 <-- build time in seconds for all Calcite modules
> 20.1 17.8
> 20.0 17.6
> mvn org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check@validate:
> 6.x 7.8.2 <-- checkstyle version
> 8.91 4.19 <-- build time in seconds for all Calcite modules
> 8.66 4.52
> 8.38 3.49
> 8.53 3.90
> 8.32 3.80{noformat}
> A side note: {{net.hydromatic.toolbox.checkstyle.HydromaticFileSetCheck}} is
> not compatible with Checkstyle 8.x
> Note: existing {{<property name="classes" value="java.lang.Boolean,
> java.lang.String"/>}} blocks use of {{new String(...)}} which is sometimes
> required to convert {{byte[] + encoding}} to {{String}}.
> I have added {{// CHECKSTYLE: IGNORE 0}} in the relevant places, and I have
> no idea how it worked before.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
