[
https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623414#comment-16623414
]
Hongze Zhang commented on CALCITE-2535:
---------------------------------------
[~vladimirsitnikov]
{quote}I don't quite get the distinction between SqlValidatorTester and
SqlRuntimeTester. Isn't a single class enough?
{quote}
Thank for point out this, the fix is to make sure the tests run, and the Tester
implementation part might still be optimizable.
The test class SqlOperatorTest.java requires a tester testing validation only,
which ignores the runtime part. Whereas the CalciteOperatorTest.java requires a
tester testing both validation and run time execution, and because of the two
test classes shares the same test code, basically we need two different testers
for them.
IMO this point still might confuses developers, but myself have not come up a
perfect optimization way yet.
> Runtime failure check not working in SqlTesterImpl.java
> -------------------------------------------------------
>
> Key: CALCITE-2535
> URL: https://issues.apache.org/jira/browse/CALCITE-2535
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Hongze Zhang
> Assignee: Julian Hyde
> Priority: Major
> Fix For: 1.18.0
>
>
> Problem at SqlTesterImpl#checkFails:
> When argument "runtime" is specified as true, error assertion and error
> message matching will not be performed.
> This issue could result in wrong test result in SqlOperatorBaseTest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
