[
https://issues.apache.org/jira/browse/CALCITE-2594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627631#comment-16627631
]
ASF GitHub Bot commented on CALCITE-2594:
-----------------------------------------
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/calcite-avatica/pull/74#discussion_r220270255
--- Diff: pom.xml ---
@@ -410,8 +415,8 @@ limitations under the License.
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
- <source>8</source>
- <target>8</target>
+ <source>${maven.compiler.source}</source>
--- End diff --
Yea I think so too. I just wanted to be sure we set the same version in one
spot. Afraid someone comes along later and updates the 8 to a 9/10/11 and
doesn't change the maven.compiler.source/maven.compiler.target properties.
> Ensure forbiddenapis and maven-compiler use the correct JDK version
> -------------------------------------------------------------------
>
> Key: CALCITE-2594
> URL: https://issues.apache.org/jira/browse/CALCITE-2594
> Project: Calcite
> Issue Type: Bug
> Components: avatica, core
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Major
> Fix For: avatica-1.13.0, 1.18.0
>
>
> I was looking at the build logs the other day for Avatica and noticed the
> following:
> {noformat}
> [INFO] --- forbiddenapis:2.6:testCheck (default) @ avatica-core ---
> [INFO] Scanning for classes to check...
> [INFO] Reading bundled API signatures: jdk-unsafe-1.7
> [INFO] Reading bundled API signatures: jdk-deprecated-1.7{noformat}
> The 1.7 being the JDK version that forbiddenapis is picking up for the
> signatures. I double checked that we were setting the compiler to use JDK 8
> and moved on.
> Today I was looking at the ASF POM for a different project and noticed:
> {code:java}
> <maven.compiler.source>1.7</maven.compiler.source>
> <maven.compiler.target>1.7</maven.compiler.target>
> {code}
> I double checked the forbiddenapis docs and those two properties are used to
> determine the correct signatures.
> This Jira is to override the base ASF POM properties in the top level pom to
> be the following:
> {code:java}
> <maven.compiler.source>8</maven.compiler.source>
> <maven.compiler.target>8</maven.compiler.target>
> {code}
> After making that change locally I can see forbiddenapis picking up the
> correct signatures.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
