[
https://issues.apache.org/jira/browse/CALCITE-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637495#comment-16637495
]
Julian Hyde commented on CALCITE-2529:
--------------------------------------
Either of us could do it. I haven't got to it just because I'm short on time.
This has been a long-standing problem, and I'll be delighted if you've fixed it
with such an elegant fix. I think there are some more JIRA cases (some closed,
some open) related to this. Can you do a quick search, and link them to this
case? We could possibly back out some of the redundant functions we added due
to this problem in the past.
Your change from {{family}} to {{number}} would make {{boolean}} and {{void}}
assignable to each other, I think, which is wrong. So I think it's better to
just merge the two number families into one.
I think your commit comment should describe the problem, i.e. that the code
generator cannot use the overload. The underlying problem is the code
generator's flawed understanding of which Java types are assignable, so mention
that in the commit description.
> linq4j should promote integer to floating point when generating function calls
> ------------------------------------------------------------------------------
>
> Key: CALCITE-2529
> URL: https://issues.apache.org/jira/browse/CALCITE-2529
> Project: Calcite
> Issue Type: Improvement
> Reporter: Andrew Pilloud
> Assignee: Julian Hyde
> Priority: Major
>
> For example, I get "RuntimeException: while resolving method 'atan2[double,
> int]'" when trying to execute a query with "ATAN2(c_double, 2)" (where
> c_double is a column containing the double type). atan2[double, double]
> should resolve as a valid implementation in this case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
