[ 
https://issues.apache.org/jira/browse/CALCITE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641763#comment-16641763
 ] 

Piotr Bojko commented on CALCITE-2609:
--------------------------------------

I've seen it now. Thank you.

 I understand that you want to push dynamic/bindable down to underlying jdbc 
shemas, eventually.

My thinking is as follows. There is a fix and there is an optimization. My 
simple change fixes the bug and extends support for bindable parameters to more 
workinig cases. If anyone is willing to deliver an optimization described in 
CALCITE-563, then its work interferes with my fix in two ways:
# One will remove a fix - this is a simple removal, considering that 
optimization will change JdbcRules anyway.
# One will have more tests already to guard Calcite stability when working on 
an optimization.

As for me I would go with my fix and then plan the optimization, but I am not 
an active Calcite maintainer - this is only my suggestion. It is solely up to 
you guys :) 

> Dynamic parameters ? pushed to underlying jdbc schema
> -----------------------------------------------------
>
>                 Key: CALCITE-2609
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2609
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.17.0
>            Reporter: Piotr Bojko
>            Assignee: Julian Hyde
>            Priority: Major
>
> When using PreparedStatement parameters "?" they can be pushed down to jdbc 
> subschemas which cause an error.
> RexDynamicParam should no be pushed to jdbc schema.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to