[ 
https://issues.apache.org/jira/browse/CALCITE-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644966#comment-16644966
 ] 

Ted Xu commented on CALCITE-2616:
---------------------------------

We have encountered the same issue here. The root cause should be some hard 
coded charset in SqlUtil#translateCharacterSetName, which is invoked by 
NlsString.

In fact, from our profiling result, the cost of checking charset correctness in 
NlsString is very high. Considering it is not a critical path, we should remove 
that piece of code. [~julianhyde] 

> Can't create Unicode literal by RelBuilder
> ------------------------------------------
>
>                 Key: CALCITE-2616
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2616
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: Anton Haidai
>            Assignee: Julian Hyde
>            Priority: Major
>
> Test in RelBuilderTest to reproduce the issue:
> {code:java}
> @Test public void testScanWithFilterByUnicodeValue() {
>   final RelBuilder builder = RelBuilder.create(config().build());
>   RelNode root =
>       builder.scan("EMP")
>           .filter(
>               builder.call(SqlStdOperatorTable.EQUALS,
>                   builder.field("ENAME"),
>                   builder.literal("Петро ピーター")
>               )
>           )
>           .build();
> }
> {code}
>  Result:
> org.apache.calcite.runtime.CalciteException: Failed to encode 'Петро ピーター' in 
> character set 'ISO-8859-1'
> Possible workaround: create saffron.properties with the following property
> saffron.default.charset=UTF-16LE
> But UTF-8 will not work as a value of this property, see 
> SqlUtil.translateCharacterSetName
> Related code:
>  * SqlUtil.translateCharacterSetName(charsetName)
>  * RelDataTypeFactoryImpl.getDefaultCharset()
>  * SaffronProperties
>  Could it be considered to switch defaults from "ISO-8859-1" to "UTF-8" in 
> SaffronProperties?
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to