[ 
https://issues.apache.org/jira/browse/CALCITE-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674558#comment-16674558
 ] 

Julian Hyde commented on CALCITE-1912:
--------------------------------------

I reviewed your change. A few comments:
* Please document SQL syntax in reference.md
* Why the did error message change in lateral.iq?
* Remove the commented-out lines in SqlValidatorImpl
* I think you should rename SqlTemporal to SqlSnapshot. (It is an operation 
that converts a temporal table to a non-temporal table at a moment in time.)
* Add a method RelBuilder.snapshot, and document it in algebra.md
* Rather than {{TemporalTableScan(table, period)}} I think you should have 
{{Snapshot(TableScan(table), period)}}. In other words, Snapshot is a 
relational operator that applies to any relation, not just table scans. (For 
now, it's OK if we only implement it if it is directly above a table scan.) 
What do you think?

> Support "FOR SYSTEM_TIME AS OF" in regular queries
> --------------------------------------------------
>
>                 Key: CALCITE-1912
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1912
>             Project: Calcite
>          Issue Type: New Feature
>            Reporter: Jark Wu
>            Assignee: Julian Hyde
>            Priority: Major
>             Fix For: 1.18.0
>
>
> As discussed in mailling list[1], we hope to support "FOR SYSTEM_TIME AS OF" 
> in Calcite to retrieve table contents as of a given point in time. 
> [1] 
> https://lists.apache.org/thread.html/f877f356a8365bf74ea7d8e4a171224104d653cf73861afb2901a58f@%3Cdev.calcite.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to