[
https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677545#comment-16677545
]
Hongze Zhang edited comment on CALCITE-2266 at 11/7/18 2:15 AM:
----------------------------------------------------------------
Hi [~julianhyde],
{quote}Do you still need to up the stack size, following my changes in
CALCITE-2405? I found that breaking up NonReservedKeyWord() into smaller
methods - none of which breaks the de facto maximum nesting depth of ~300 -
solved the problem.
{quote}
Thank you for mentioning this, I have revert the stack size changes on latest
commit of the PR, yet I did not make a test about if the StackOverflowError
still exists after CALCITE-2405 solved (Calcite's Travis seems to be
unavailable now), but I believe it was fixed.
was (Author: zhztheplayer):
Hi [~julianhyde],
{quote}Do you still need to up the stack size, following my changes in
CALCITE-2405? I found that breaking up NonReservedKeyWord() into smaller
methods - none of which breaks the de facto maximum nesting depth of ~300 -
solved the problem.
{quote}
Thank you for mentioning this, I have revert the stack size changes, yet I did
not make a test about if the StackOverflowError still exists after CALCITE-2405
solved (Calcite's Travis seems to be unavailable now), but I believe it was
fixed.
> Implement SQL 2016 JSON functions
> ---------------------------------
>
> Key: CALCITE-2266
> URL: https://issues.apache.org/jira/browse/CALCITE-2266
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Michael Mior
> Priority: Major
> Fix For: 1.18.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
