[ 
https://issues.apache.org/jira/browse/CALCITE-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683376#comment-16683376
 ] 

Julian Hyde commented on CALCITE-2663:
--------------------------------------

Thanks for logging this JIRA case for [PR 
#908|https://github.com/apache/calcite/pull/908]. If you still want to 
contribute this, can you re-open the PR? We will close it only when it has been 
accepted.

Review comments:
* Can you also support "CREATE OR REPLACE FUNCTION", and "DROP FUNCTION".
* Probably SqlCreateFunction should extend SqlCreate
* Put it in createStatementParserMethods not statementParserMethods
* You assign pos on two consecutive lines.
* Use {{CompoundIdentifier()}}, not <DOT>.
* Add syntax to reference.md



> CREATE FUNCTION SQL statement
> -----------------------------
>
>                 Key: CALCITE-2663
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2663
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.16.0, 1.17.0
>            Reporter: ambition
>            Assignee: Julian Hyde
>            Priority: Minor
>             Fix For: 1.16.0, 1.17.0
>
>
> support create function statement like hive:
>  
>  
> {code:java}
> CREATE FUNCTION [db_name.]function_name AS class_name
>   [USING JAR|FILE|ARCHIVE 'file_uri' [, JAR|FILE|ARCHIVE 'file_uri'] ];
> {code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to