[
https://issues.apache.org/jira/browse/CALCITE-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
godfrey he updated CALCITE-2690:
--------------------------------
Description: Currently, We use a lot of {{RelNode}}'s {{toString}} method
to get digest in Calcite project. However the semantics of {{toString}} method
is ambiguity. If some developers do not know the {{toString}} value of a
{{RelNode}} will be used as digest and override {{toString}} method
arbitrarily, the optimization result will be unexpected. So I suggest that we
should use {{getDescription}} instead of {{toString}} to get {{RelNode}}'s
digest. (was: Currently, We use a lot of RelNode's toString method to get
digest in Calcite project. However the semantics of `toString` method is
ambiguity. If some developers do not know the toString value of a RelNode will
be used as digest and override toString method arbitrarily, the optimization
result will be unexpected. So I suggest that we should use ·getDescription·
instead of ·toString· to get RelNode's digest in Calcite.)
> Uses `getDescription` instead of `toString` when gets RelNode's digest
> ----------------------------------------------------------------------
>
> Key: CALCITE-2690
> URL: https://issues.apache.org/jira/browse/CALCITE-2690
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: godfrey he
> Assignee: Julian Hyde
> Priority: Major
>
> Currently, We use a lot of {{RelNode}}'s {{toString}} method to get digest in
> Calcite project. However the semantics of {{toString}} method is ambiguity.
> If some developers do not know the {{toString}} value of a {{RelNode}} will
> be used as digest and override {{toString}} method arbitrarily, the
> optimization result will be unexpected. So I suggest that we should use
> {{getDescription}} instead of {{toString}} to get {{RelNode}}'s digest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
