[
https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703592#comment-16703592
]
Julian Hyde commented on CALCITE-2662:
--------------------------------------
The fact that you are able to use a StringReader is a good sign that your
approach will work.
I saw you changed a comment from present tense to future tense. Keep it in
present tense, please. Future tense is less direct, because it sounds
conditional.
Still need a test with parse error and conditions.
> Planner: allow parsing directly a stream instead of a java.lang.String
> ----------------------------------------------------------------------
>
> Key: CALCITE-2662
> URL: https://issues.apache.org/jira/browse/CALCITE-2662
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.17.0
> Reporter: Enrico Olivelli
> Assignee: Julian Hyde
> Priority: Major
>
> In 1.17.0 the org.apache.calcite.tools.Planner interface only accept a
> java.lang.String as input.
> In order to reduce memory allocations and copies it will be useful that the
> planner could accept the query in a more 'raw' format.
> Creating a java.lang.String is very expensive, and if your "query" is coming
> from the network (think about a Netty Direct memory ByteBuf) you are forced
> to create a copy of the text of the query.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
