[
https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705653#comment-16705653
]
Julian Hyde commented on CALCITE-2619:
--------------------------------------
Reviewing:
* The name ByteString is confusingly similar to Avatica's ByteString, which we
use widely in Calcite. I propose to replace your ByteString with a pair of
(Avatica's ByteString, Charset)
* I see you use Charset.defaultCharset() in a couple of places. I think it's
better to never use that. (Similarly Locale.getDefault() and
TimeZone.getDefault().)
> Reduce string literal creation cost by removing unnecessary charset check
> -------------------------------------------------------------------------
>
> Key: CALCITE-2619
> URL: https://issues.apache.org/jira/browse/CALCITE-2619
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Ted Xu
> Assignee: Julian Hyde
> Priority: Major
>
> The cost of creating NlsString is very high, due to its charset check. In
> some cases, e.g., expression evaluate because of Partition Prune, the
> NlsString creation costs 40%+ of total executor's overhead.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
