[ 
https://issues.apache.org/jira/browse/CALCITE-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709500#comment-16709500
 ] 

Francis Chuang edited comment on CALCITE-2725 at 12/5/18 1:31 AM:
------------------------------------------------------------------

Thanks for opening this JIRA, Julian.

The announcement for Avatica 1.13 was rejected because we linked to the Github 
repo on the downloads page: 
{code:java}
Sorry, but the download page has some problems.
1) the SHA256 hash for the latest release does not exist. Looks like you
 have changed to 512
2) the page includes links to GitHub. Whilst a specific commit may have
 been voted on as part of a release, the rest of the repo has not been
 formally released. Please remove the links to Github.
When these isses have been fixed, please resubmit the announce email.
Sebb.
{code}
>From my reading of the second point, I think we should avoid linking to the 
>repo as there may be other unreleased code in it.

For SHA512,  I thought CALCITE-2725 was resolved for Calcite, but it appears to 
only be fixed for Avatica. I will revert this change. I think we should reopen 
CALCITE-2486 and get it in for Calcite 1.19.

I'll update the commit to include the Jira issue number and revert the change 
for the digest.


was (Author: francischuang):
Thanks for opening this JIRA, Julian.

The announcement for Avatica 1.13 was rejected because we linked to Github on 
the downloads page: 
{code:java}
Sorry, but the download page has some problems.
1) the SHA256 hash for the latest release does not exist. Looks like you
 have changed to 512
2) the page includes links to GitHub. Whilst a specific commit may have
 been voted on as part of a release, the rest of the repo has not been
 formally released. Please remove the links to Github.
When these isses have been fixed, please resubmit the announce email.
Sebb.
{code}

 From my reading of the second point, I think we should avoid linking to the 
repo as there may be other unreleased code in it.

For SHA512,  I thought CALCITE-2725 was resolved for Calcite, but it appears to 
only be fixed for Avatica. I will revert this change. I think we should reopen 
CALCITE-2486 and get it in for Calcite 1.19.

I'll update the commit to include the Jira issue number and revert the change 
for the digest.

> Link to SHA512 digest and remove link to Github commit per ASF policy
> ---------------------------------------------------------------------
>
>                 Key: CALCITE-2725
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2725
>             Project: Calcite
>          Issue Type: Bug
>          Components: site
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>            Priority: Major
>             Fix For: 1.19.0
>
>
> Link to SHA512 digest and remove link to Github commit per ASF policy.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to