[
https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715225#comment-16715225
]
Stamatis Zampetakis commented on CALCITE-2730:
----------------------------------------------
Even before the introduction of Collections#replaceAll the method that was used
to replace a term in various places was:
{code:java}
terms.set(terms.indexOf(e), ...)
{code}
which was again based on reference equality ('=='). In other places, where
value based equality was required (before the changes by [~kgyrtkirk]) it was
based on RexNode#toString.
I pushed a commit reverting back to reference equality in a couple of places
and tests seem to pass fine. Do you see an immediate problem with this change?
> RelBuilder simplifies a filter with duplicate conjunction to empty
> ------------------------------------------------------------------
>
> Key: CALCITE-2730
> URL: https://issues.apache.org/jira/browse/CALCITE-2730
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: next
> Reporter: Stamatis Zampetakis
> Assignee: Julian Hyde
> Priority: Major
> Fix For: 1.18.0
>
>
> Regression from 1.17.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
