[
https://issues.apache.org/jira/browse/CALCITE-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720799#comment-16720799
]
Jesus Camacho Rodriguez commented on CALCITE-2673:
--------------------------------------------------
I will push the addendum; it is not risky since
{{SqlFunction.supportsFunction}} is not used in Calcite. It is quite bad that
it is not used and it does not have any tests... I have created CALCITE-2740 to
follow up on this.
> Default implementation of SqlDialect should not support pushing all functions
> -----------------------------------------------------------------------------
>
> Key: CALCITE-2673
> URL: https://issues.apache.org/jira/browse/CALCITE-2673
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Priority: Major
> Fix For: 1.18.0
>
>
> SqlDialect contains a 'supportsFunction' that can be used by rules to know
> whether a certain function is supported in the given dialect, e.g., to choose
> whether to push a Filter expression to JDBC, etc.
> The default implementation of 'supportsFunction' always returns true.
> I believe a better idea would be to support in the default implementation for
> the method the most common SQL functions. Then each dialect can override that
> behavior and expand/limit the supported functions, e.g., JethroDataDialect
> already does that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
