[ 
https://issues.apache.org/jira/browse/CALCITE-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737473#comment-16737473
 ] 

Julian Hyde commented on CALCITE-2301:
--------------------------------------

[~vlsi] I see you added a PR. It looks very good. It still needs a test, and I 
think we need to set the deadline based on query execution start time, 
otherwise we may have a race condition.

> JDBC adapter: use query timeout from the top-level statement
> ------------------------------------------------------------
>
>                 Key: CALCITE-2301
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2301
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.16.0
>            Reporter: Fan Yang
>            Assignee: Julian Hyde
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: next
>
>
> It's not a good idea to have the magic number here. Also, databases may not 
> get back within 10 second for various reasons (e.g., in the case of JDBC 
> schema).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to