[
https://issues.apache.org/jira/browse/CALCITE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766926#comment-16766926
]
Zoltan Haindrich commented on CALCITE-2838:
-------------------------------------------
{quote} Make sure that there aren't a lot of changes happening for very little
purpose{quote}
I'm not sure if I understand correctly you comment, please let me rephrase it
and correct me if I'm mistaken:
{quote}Instead of making a number of smaller changes; do one bigger{quote}
If that is the case; I could try to make that happen - but I always try to
decompose what I'm doing to smaller changes if possible - because in a smaller
changeset it is easier to spot problems.
I feel that submitting the following tickets together
(CALCITE-2838,CALCITE-2839,CALCITE-2840 and CALCITE-2841) would be of course
possible - but it would be harder to describe what happens in the patch, beyond
something like "improvements to simplification"; actually it would make my life
easier as well - right now I have it on the same development branch.
> Simplification: Remove redundant IS TRUE checks
> -----------------------------------------------
>
> Key: CALCITE-2838
> URL: https://issues.apache.org/jira/browse/CALCITE-2838
> Project: Calcite
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
>
> In case simplifcation is already processing in unknownAsFalse mode, {{expr IS
> TRUE}} is redundant - and may just prevent further optimizations from
> happening:
> {code}
> @Test public void testRedundantIsTrue() {
> // in case of unknownAsFalse
> // x is TRUE <=> x
> checkSimplify3(isTrue(vBool(1)),
> "IS TRUE(?0.bool1)",
> "?0.bool1",
> "IS TRUE(?0.bool1)");
> }
> {code}
> there are some further possibilities
> {code}
> (unknownAsTrue) x is NOT FALSE <=> x
> (unknownAsTrue) x is FALSE <=> not x
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
