[ 
https://issues.apache.org/jira/browse/CALCITE-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774723#comment-16774723
 ] 

Andrei Sereda edited comment on CALCITE-2859 at 2/22/19 3:46 AM:
-----------------------------------------------------------------

Perhaps not directly related to this issue but I like the idea of [owner 
library|http://owner.aeonbits.org/] which maps java properties directly to 
interface. 

Much prefer {{calciteConfig.getCacheMaxSize()}}  over 
{{config.getInt("calcite.cache.maxSize")}} 

For complex configurations [type-safe 
config|https://github.com/lightbend/config] is nice (which can also be mapped 
to objects using JSON). 

Can this also be leveraged for other (possibly private) calcite properties like 
{{SqlToRelConverter.DEFAULT_IN_SUB_QUERY_THRESHOLD}}


was (Author: asereda):
Perhaps not directly related to this issue but I like the idea of [owner 
library|http://owner.aeonbits.org/] which maps java properties directly to 
interface. 

Much prefer {{calciteConfig.getCacheMaxSize()}}  over 
{{config.getInt("calcite.cache.maxSize")}} 

For complex configurations [type-safe 
config|https://github.com/lightbend/config] is nice (which can also be mapped 
to objects using JSON). 

> Centralize Calcite system properties
> ------------------------------------
>
>                 Key: CALCITE-2859
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2859
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.18.0
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Trivial
>             Fix For: 1.19.0
>
>
> Currently there are various system (jvm) properties exploited by Calcite 
> which are distributed all over the codebase. System properties are part of 
> the public API so they should be easily accessible and well documented. 
> The goal is to centralize all system properties with the "calcite" prefix 
> under a common class/interface/enum. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to