[
https://issues.apache.org/jira/browse/CALCITE-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775453#comment-16775453
]
Julian Hyde commented on CALCITE-2859:
--------------------------------------
+1 to the PR. Thanks, [~zabetak].
Regarding SaffronProperties. Can you deprecate it and add its 6 properties
allowInfiniteCostConverters, defaultCharset, defaultCollation,
defaultCollationStrength, metadataHandlerCacheMaximumSize into
CalciteSystemProperty. So, no code will be using SaffronProperties anymore.
Keep the properties in the "saffron." namespace for now, but you can add a
"calcite." alias if it's not too hard.
I like the general pattern of SaffronProperties - an interface with
annotations, implemented via reflection - but we can discuss refactoring
CalciteSystemProperty in a later change. [~zabetak] has done the most important
part already.
> Centralize Calcite system properties
> ------------------------------------
>
> Key: CALCITE-2859
> URL: https://issues.apache.org/jira/browse/CALCITE-2859
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.18.0
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.19.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently there are various system (jvm) properties exploited by Calcite
> which are distributed all over the codebase. System properties are part of
> the public API so they should be easily accessible and well documented.
> The goal is to centralize all system properties with the "calcite" prefix
> under a common class/interface/enum.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
