[
https://issues.apache.org/jira/browse/CALCITE-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790981#comment-16790981
]
Kevin Risden commented on CALCITE-2918:
---------------------------------------
I'm not sure the integration test against postgres has been run recently. I
went back to branch-1.18 and get the AbstractMethodError errors identified
here: CALCITE-2732 - Upgrade postgresql driver version. CALCITE-2732 didn't
upgrade the Postgres driver version but changed from JDBC 3 to JDBC 4.1 of the
driver.
I was going to try to bisect but that may not be possible since can't run the
integration tests with branch-1.18 due to CALCITE-2732.
So I guess the question is best way to move forward from here. Here are the
options I think:
* Figure out if something changed in 1.19.0 in relation to parenthesis
** Would require testing branch-1.18 with CALCITE-2732 applied
* Test against Postgres 9.6 instead of 9.3
** Would require upgrading calcite-test-dataset vm to Postgres 9.6
I am leaning towards fixing the parenthesis (regardless if the change was
introduced in 1.19.0 or not.) It seems broken to rely on underlying DB to have
correct operator precedence.
> Integration tests against postgres are broken
> ---------------------------------------------
>
> Key: CALCITE-2918
> URL: https://issues.apache.org/jira/browse/CALCITE-2918
> Project: Calcite
> Issue Type: Bug
> Reporter: Kevin Risden
> Priority: Blocker
> Fix For: 1.19.0
>
>
> As part of the release process, integration testing against postgres found a
> failure.
> {code:java}
> ./mvnw verify -Pit
> [INFO] -------------------------------------------------------
> [INFO] T E S T S
> [INFO] -------------------------------------------------------
> [INFO] Running org.apache.calcite.test.JdbcTest
> 2019-03-11 11:23:41,539 [main] INFO - open start - state modified
> 2019-03-11 11:23:41,555 [main] INFO - Checkpoint start
> 2019-03-11 11:23:41,555 [main] INFO - Checkpoint end - txts: 25
> [ERROR] Tests run: 290, Failures: 0, Errors: 1, Skipped: 21, Time elapsed:
> 65.154 s <<< FAILURE! - in org.apache.calcite.test.JdbcTest
> [ERROR] testIsNotDistinctInFilter(org.apache.calcite.test.JdbcTest) Time
> elapsed: 0.041 s <<< ERROR!
> java.sql.SQLException:
> Error while executing SQL "select *
> from "foodmart"."employee" as e1
> where e1."last_name" is distinct from e1."last_name"": While executing SQL
> [SELECT *
> FROM "foodmart"."employee"
> WHERE ("last_name" IS NOT NULL OR "last_name" IS NOT NULL) AND "last_name" =
> "last_name" IS NOT TRUE] on JDBC sub-schema
> at
> org.apache.calcite.test.JdbcTest.testIsNotDistinctInFilter(JdbcTest.java:1585)
> Caused by: java.lang.RuntimeException:
> While executing SQL [SELECT *
> FROM "foodmart"."employee"
> WHERE ("last_name" IS NOT NULL OR "last_name" IS NOT NULL) AND "last_name" =
> "last_name" IS NOT TRUE] on JDBC sub-schema
> at
> org.apache.calcite.test.JdbcTest.testIsNotDistinctInFilter(JdbcTest.java:1585)
> Caused by: org.postgresql.util.PSQLException:
> ERROR: argument of IS NOT TRUE must be type boolean, not type character
> varying
> Position: 114
> at
> org.apache.calcite.test.JdbcTest.testIsNotDistinctInFilter(JdbcTest.java:1585)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
